dd: fix various i64 max errors#12965
Open
zhw2101024 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Forgot to test on windows, will try again later. |
|
GNU testsuite comparison: |
zhw2101024
force-pushed
the
fix_various_i64_max_errors
branch
from
c3fd4b4 to
f4cd13c
Compare
Merging this PR will improve performance by 3.03%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
26 ms | 25.2 ms | +3.03% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing zhw2101024:fix_various_i64_max_errors (f5d0f15) with main (d01be5b)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
zhw2101024
force-pushed
the
fix_various_i64_max_errors
branch
3 times, most recently
from
9987869 to
1762afa
Compare
zhw2101024
force-pushed
the
fix_various_i64_max_errors
branch
from
1762afa to
f5d0f15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12964
There's some cases on the i64 boundary where uutils dd cannot handle correctly.